Fastapi + Gunicorn example in README#812
Conversation
| def make_metrics_app(): | ||
| registry = CollectorRegistry() | ||
| multiprocess.MultiProcessCollector(registry) | ||
| return prometheus_client.make_asgi_app(registry=registry) |
There was a problem hiding this comment.
@ashirviskas should be based on the import
return make_asgi_app(registry=registry)There was a problem hiding this comment.
I might be late, but I just fixed it
csmarchbanks
left a comment
csmarchbanks
left a comment
There was a problem hiding this comment.
Generally looks good to me with a small nit. In addition, the second commit needs to be signed off.
|
|
||
| metrics_app = make_metrics_app() | ||
| app.mount("/metrics", metrics_app)) | ||
|
|
|
|
||
|
|
||
| metrics_app = make_metrics_app() | ||
| app.mount("/metrics", metrics_app)) |
There was a problem hiding this comment.
remove double ) at the end of line
|
I am still learning a bit when it comes to pythons async implementation but should it not be noted in the Multiprocess portion that multiprocess mode uses blocking io calls (to a memory mapped file so it is quick, but will still blocks the event loop)? |
|
I know this isn't merged yet, but is it good practice? |
|
It's the 11 month anniversary of this PR, are we still deliberating or could this be merged in? As per the motive of the original #810, having this in the README.md would have saved significant time. |
|
I cannot merge this without the DCO being signed for all commits.
As the readme mentions, that is best practice to avoid metrics registering themselves with the multiprocess registry. Since the registry is only created inside of the create app function I think this approach is correct. |
|
Whats the easiest way I could resign all the commits? EDIT: Amended the commit messages, just no idea how to trigger DCO to rerun. |
ashirviskas
force-pushed
the
feature/readme_fastapi_gunicorn
branch
from
9a7198a to
b1c9ce5
Compare
Also provided additional multiprocessing instructions for FastAPI + Gunicorn setup with code examples as per this issue: prometheus#810 Signed-off-by: Matas Minelga <minematas@gmail.com>
Signed-off-by: Matas Minelga <minematas@gmail.com>
Removed extra characters Signed-off-by: Matas Minelga <minematas@gmail.com>
ashirviskas
force-pushed
the
feature/readme_fastapi_gunicorn
branch
from
b1c9ce5 to
c4af65e
Compare
csmarchbanks
left a comment
csmarchbanks
left a comment
There was a problem hiding this comment.
Looks like it ran when you force pushed (as it should). Thanks!
|
Wow! Thanks everyone for sorting today and for creating the additional PR in the first place. |
7 participants
Also provided additional multiprocessing instructions for FastAPI + Gunicorn setup with code examples as per this issue: #810
Signed-off-by: Matas Minelga minematas@gmail.com